Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal functions _getInitializedVersion and _isInitializing #3598

Merged
merged 4 commits into from
Aug 18, 2022

Conversation

hrik2001
Copy link
Contributor

@hrik2001 hrik2001 commented Aug 4, 2022

Fixes #3584
@frangio, once you are okay with this. I would add the functions in InitializableMock.sol SingleInheritanceInitializableMock.sol MultipleInitializableMock.sol and write tests accordingly. Pardon me if I have messed up something since I am a novice.

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx
Copy link
Collaborator

Amxx commented Aug 8, 2022

Thank you @hrik2001 for this PR.

We'll need tests and a changelog entry. Otherwize looks good

@frangio frangio changed the title Added internal functions _getInitializedVersion and _isInitializing as required by #3584 Added internal functions _getInitializedVersion and _isInitializing Aug 10, 2022
@hrik2001
Copy link
Contributor Author

@Amxx Hi! I have made changes accordingly (tests and changelog). Although some tests are failing. Is that worrying? Do let me know if I have to make more changes. Thank you!

@hrik2001
Copy link
Contributor Author

@Amxx oops, my bad, looks like all the tests have passed and I might have looked at the old test results. Please let me know your review and sorry for sounding like a broken record 😅

Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@frangio frangio changed the title Added internal functions _getInitializedVersion and _isInitializing Add internal functions _getInitializedVersion and _isInitializing Aug 18, 2022
@frangio frangio merged commit 26cf47a into OpenZeppelin:master Aug 18, 2022
ronhuafeng added a commit to ronhuafeng/openzeppelin-contracts that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add internal functions to get values of _initialized and _initializing
3 participants